-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SVG flip when svg.image_noscale is True #1674
Conversation
Thanks! It worked for me. Since the line |
@tkanmae Yes, you are correct. I will move it. Thank you. |
I rebased so as not to create an unnecessary commit. |
Looks good to me. I wonder if we should add an image comparison test for the |
Hm, moving the |
@tkanmae So, there is a call to |
Sorry, I missed the point. Hope it will soon get merged. |
Fix SVG flip when svg.image_noscale is True
Great work for a pretty serious bug. @dmcdougall : Like the new avatar, btw. |
@mdboom ty |
Fixes #1673.
Not sure if this is the correct solution, but it appears to work for me, and all the tests pass locally with py27.